PHP :: Request #75206 :: porting to php7

porting to php7

Submitted:

2017-09-14 05:38 UTC

Modified:

2018-06-24 04:25 UTC

Votes:	2
Avg. Score:	5.0 ± 0.0
Reproduced:	2 of 2 (100.0%)
Same Version:	2 (100.0%)
Same OS:	1 (50.0%)

From:

at dot mitani at gmail dot com

Assigned:

Status:

No Feedback

Package:

svn (PECL)

PHP Version:

7.0.23

OS:

Linux

Private report:

CVE-ID:

None

View Developer Edit

[2017-09-14 05:38 UTC] at dot mitani at gmail dot com

Description:
------------
---
From manual page: http://www.php.net/book.svn
---
I'd like to use svn library with php7. However even the latest version of svn package is not working with php7.
Therefore, I made a patch for it. It seems work in my environment as follows.
OS:CentOS6.9
PHP:7.0.23
Subversion:1.8.19
gcc:4.4.7

If you have interested in it, please check my patch.

Thank you.

Patches

php7again.diff (last revision 2017-11-27 16:12 UTC by cpigott at rapitasystems dot com)
svn.patch (last revision 2017-09-14 05:39 UTC by at dot mitani at gmail dot com)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2017-09-14 08:38 UTC] cmb@php.net

Related To: Bug #74068

[2017-11-07 13:37 UTC] david dot little2 at gmail dot com

Thank you!  This patch worked for me with the following setup:

OS: CentOS 7.4.1708
PHP: 7.1.11
Subversion: 1.7.14
gcc: 4.8.5

[2017-11-20 03:46 UTC] alan_k@php.net

-Status: Open +Status: Feedback

[2017-11-20 03:46 UTC] alan_k@php.net

This has been committed to SVN

http://svn.php.net/viewvc/pecl/svn/trunk/

testing would be appreciated before it get's released

Thanks

[2017-11-24 16:33 UTC] cpigott at rapitasystems dot com

Out of interest, when will the release come? I've got a thing that's waiting on this, and it'd be great if I didn't have to build it myself or downgrade to PHP5.6

[2017-11-25 04:04 UTC] alan_k@php.net

As soon as I get confirmation that the code currently in SVN works

Otherwise it as to wait till I get time to test it.

Regards
Alan

[2017-11-27 16:11 UTC] cpigott at rapitasystems dot com

Seems just as well I did. Didn't even compile on my Ubuntu 16.04 system

Patch attached fixes compilation issues, along with a few warnings (const "correctness", mostly) - still a lot of svn deprecated functions being used though.

Most notably, reverts r254248 - http://svn.php.net/viewvc/pecl/svn/trunk/svn.c?r1=253828&r2=254248 - not sure why this change was made, but it broke half the tests and seems counter intuative anyway. Didn't see it mentioned anywhere in the changelog either.

All tests except status (hardcoded path values) pass, but I get that those tests don't nearly cover everything - probably needs a realworld test still :)

[2018-02-08 21:06 UTC] buccim2 at gene dot com

Any Updates on getting that additional patch merged in? Have to manually apply the patch to trunk before building in my docker env.

[2018-02-12 06:25 UTC] alan_k@php.net

Ok - have another go - I've patched it with the last patch..

Hopefully that fixes it.

[2018-06-24 04:25 UTC] pecl-dev at lists dot php dot net

No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.

	php.net \| support \| documentation \| report a bug \| advanced search \| search howto \| statistics \| random bug \| login
go to bug id or search bugs for


Copyright © 2001-2024 The PHP Group All rights reserved.	Last updated: Sun Nov 10 20:01:29 2024 UTC